uforum Issue Tracker Rss Feed

Commented Issue: Error on deleted user [7597]

mortenbock — Mon, 29 Nov 2010 16:35:50 GMT

When a user is deleted and he has made posts the forum crashes.
Comments: ** Comment from web user: mortenbock **

Looks a bit like this issue, which should be fixed:
http://uforum.codeplex.com/workitem/7060

Could you be a little more specific as to how the forum "crashes"?

I assume you are running the latest Beta III?

Created Issue: Error on deleted user [7597]

NielsHenriksen — Mon, 29 Nov 2010 12:00:24 GMT

When a user is deleted and he has made posts the forum crashes.

Closed Issue: Int32 to String casting errors [7580]

mortenbock — Wed, 24 Nov 2010 16:27:01 GMT

Your last version has problems with casting Int32 to String and other way around. I tracked this down to some lines in you Comment, Forum and Topic models, in the attachment you will find a patch file to solve the issue.

In short, your database model uses Int-fields for MemberID, AuthorID, etc. But your code tries to put Strings into them, which throws up exceptions.

Thanks for this awesome project.
Comments:

Could not reproduce.

Commented Issue: Int32 to String casting errors [7580]

mortenbock — Tue, 23 Nov 2010 13:02:54 GMT

Ok, thanks for reporting back, will look into that.

Commented Issue: Int32 to String casting errors [7580]

LennardF1989 — Tue, 23 Nov 2010 10:00:23 GMT

Perhaps the DLL in the zip still holds an old version of DBInstallScripts.resx, which caused the after-commit error.

Commented Issue: Int32 to String casting errors [7580]

LennardF1989 — Tue, 23 Nov 2010 09:55:11 GMT

No, I just downloaded the latest zip of codeplex, installed the package and was doen with it. It did threw an error when I tried to install the database, but after inspection everything seemed to be created just fine in the database. I have never used uForum before that.

Commented Issue: Int32 to String casting errors [7580]

mortenbock — Mon, 22 Nov 2010 21:24:24 GMT

Lennard, are you using a database from version 0.0.7? The database schema changed for version 1.0, and the author id fields are now stored as strings instead of int's, to allow alternative membership providers to store something like a guid.

There is an sql script here http://uforum.codeplex.com/SourceControl/changeset/view/52608#760715 that should convert your tables to the new schema. Just make sure to backup(!!!!!) your data before using it, in case it fails.

Let me know if this works out, so I can close this issue.

Commented Feature: Ensure unique url for topics [7524]

LennardF1989 — Mon, 22 Nov 2010 11:42:52 GMT

Currently, a topic like

/forum-name/1234-topic-title.aspx

can be accessed through

/forum-name/1234-whatever-you-want.aspx

Proposed solution: Make sure that the url matches the url that would be written for the topic. If not, 301 redirect to the correct url.
Comments: ** Comment from web user: LennardF1989 **

Additional note: Make a check if a requested topic exists! In the current version you could type <domain>/forum/whatever, and it would open "whatever" as if it's an existing topic.

Commented Issue: Int32 to String casting errors [7580]

LennardF1989 — Mon, 22 Nov 2010 11:39:11 GMT

It also fixes XSLT not saving due to the casting errors.

Created Issue: Int32 to String casting errors [7580]

LennardF1989 — Mon, 22 Nov 2010 11:29:46 GMT

Created Issue: Image tags being stripped out [7565]

jizepi — Fri, 19 Nov 2010 16:17:26 GMT

I'm using TinyMCE with uForum to enable users to format and upload images with their posts (in the same way as on our.umbraco).

The Utills.Sanitize method has img on the whitelist RegEx, so it should be allowed, but the method also has "detailed img tag checking" which is stripping out all my image tags:

// detailed <img> tag checking
if (!IsMatch(tagname,
@"<img\s
src=""https?://[-A-Za-z0-9+&@#/%?=~_|!:,.;]+""
(\swidth=""\d{1,3}"")?
(\sheight=""\d{1,3}"")?
(\salt=""[^""]*"")?
(\stitle=""[^""]*"")?
\s?/?>"))
{
html = html.Remove(tag.Index, tag.Length);
}

I've commented this part out of Utills.cs for now to get images working again, but wondered what this was for?

Created Issue: Generic membership id converter [7544]

mortenbock — Tue, 16 Nov 2010 08:54:18 GMT

Create a generic converter that uses reflection to find the correct type of id, and then convert it to/from a string.

Created Feature: Implement Examine search [7527]

mortenbock — Sat, 13 Nov 2010 14:23:25 GMT

Would be really helpful to be able to search in the forum posts using examine.

Created Feature: Notifications on new comments [7526]

mortenbock — Sat, 13 Nov 2010 14:19:42 GMT

Allow members to sign up for notifications when comments are made on a thread.

Created Issue: Let members edit their own posts [7525]

mortenbock — Sat, 13 Nov 2010 14:17:41 GMT

The author of a post should be allowed to edit a topic/comment the he wrote.

Admins should be able to do the same for all topics/comments in their assigned forums.

Created Issue: Ensure unique url for topics [7524]

mortenbock — Sat, 13 Nov 2010 14:15:08 GMT

Closed Feature: proper error msg when mandatory fields not filled in [4413]

mortenbock — Fri, 12 Nov 2010 18:27:51 GMT

From the our.umbraco forum:

Hi,

Just been creating a post and did not fill in title and the actual post, but upon submit no error msg is shown. Please add an error msg or have field validators check for mandatory fields.

Cheers,
/Dirk
Comments:

Fixed with changeset 52390

Closed Feature: Better error message on failing eventhandler [4414]

mortenbock — Thu, 11 Nov 2010 19:40:16 GMT

This error may occur, if the site does not contain the needed db tables:

http://our.umbraco.org/projects/uforum-basics/bugs/2589-SQL-helper-Exception-on-publish

We should add a better error message from the NewForumHandler and let the user know if the tables are missing from the DB.
Comments:

Fixed with changeset 52330

Closed Issue: Error Installing SQL 2008 and IIS 7.5 [6259]

mortenbock — Thu, 11 Nov 2010 19:00:57 GMT

After clicking on updating the database i get this error:

The database failed to install properly. Errormessage: umbraco.DataLayer.SqlHelperException: Umbraco Exception (DataLayer): SQL helper exception in ExecuteNonQuery ---> System.Data.SqlClient.SqlException: Foreign key 'FK_forumTopics_umbracoNode1' references invalid table 'dbo.umbracoNode'. Could not create constraint. See previous errors. at System.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection) at System.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj) at System.Data.SqlClient.TdsParser.Run(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj) at System.Data.SqlClient.SqlCommand.RunExecuteNonQueryTds(String methodName, Boolean async) at System.Data.SqlClient.SqlCommand.InternalExecuteNonQuery(DbAsyncResult result, String methodName, Boolean sendToPipe) at System.Data.SqlClient.SqlCommand.ExecuteNonQuery() at Microsoft.ApplicationBlocks.Data.SqlHelper.ExecuteNonQuery(SqlConnection connection, CommandType commandType, String commandText, SqlParameter[] commandParameters) at Microsoft.ApplicationBlocks.Data.SqlHelper.ExecuteNonQuery(String connectionString, CommandType commandType, String commandText, SqlParameter[] commandParameters) at umbraco.DataLayer.SqlHelpers.SqlServer.SqlServerHelper.ExecuteNonQuery(String commandText, SqlParameter[] parameters) in d:\TeamCity\buildAgent\work\7380c184e9fcd3ea\umbraco\datalayer\SqlHelpers\SqlServer\SqlServerHelper.cs:line 64 at umbraco.DataLayer.SqlHelper`1.ExecuteNonQuery(String commandText, IParameter[] parameters) in d:\TeamCity\buildAgent\work\7380c184e9fcd3ea\umbraco\datalayer\SqlHelper.cs:line 217 --- End of inner exception stack trace --- at umbraco.DataLayer.SqlHelper`1.ExecuteNonQuery(String commandText, IParameter[] parameters) in d:\TeamCity\buildAgent\work\7380c184e9fcd3ea\umbraco\datalayer\SqlHelper.cs:line 223 at uForum.usercontrols.DBInstaller.installButton_Click(Object sender, EventArgs e)

The problem is when i installed umbraco 4.0.1 in the database it dosen't use "dbo." in the start of the tables, it uses the username for the sql login.
Comments:

Fixed in changeset 47484

Closed Issue: GetUserName throws exception if a member has deleted his/her account [7060]

mortenbock — Thu, 11 Nov 2010 18:56:59 GMT

If a member has written a message on the forum then deleted his/her account
uForum will throw this exception (see stacktrace):

No node exists with id '1106'
No node exists with id '1106'
at umbraco.cms.businesslogic.CMSNode.setupNode()
at umbraco.cms.businesslogic.member.Member.setupNode()
at umbraco.cms.businesslogic.CMSNode..ctor(Int32 Id)
at umbraco.cms.businesslogic.Content..ctor(Int32 id)
at umbraco.cms.businesslogic.member.Member..ctor(Int32 id)
at umbraco.providers.members.UmbracoMembershipProvider.GetUser(Object providerUserKey, Boolean userIsOnline)
at System.Web.Security.Membership.GetUser(Object providerUserKey, Boolean userIsOnline)
at System.Web.Security.Membership.GetUser(Object providerUserKey)
at uForum.Businesslogic.Services.AuthorizationService.GetUserName(String id)
at uForum.Library.Xslt.GetUserName(String id)
Comments:

Fixed by changeset 52329